Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testWriteArgumentObjectToJSONFile class modification #387

Merged
merged 3 commits into from
Jul 13, 2022
Merged

testWriteArgumentObjectToJSONFile class modification #387

merged 3 commits into from
Jul 13, 2022

Conversation

RavirajBaraiya
Copy link
Contributor

issue #377

sonalgoyal
sonalgoyal requested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the change here is to Arguments.writeArgumentsToJSON("configFromArgObject.json", args); please test and send the pr

@RavirajBaraiya
Copy link
Contributor Author

no, the change here is to Arguments.writeArgumentsToJSON("configFromArgObject.json", args); please test and send the pr

modified PR accordingly

@sonalgoyal sonalgoyal merged commit 7273694 into zinggAI:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RavirajBaraiya @sonalgoyal